search

Vauxoo / docker-odoo-image

Base docker image for instances
GNU General Public License v2.0
18 stars 29 forks source link

[REF] odoo-shippable: Slow vim open #207

Closed moylop260 closed 7 years ago

moylop260 commented 7 years ago

Running vim -V12log /.repo_requirements/odoo/addons/account/models/account.py

Output

"/.repo_requirements/odoo/addons/account/models/account.py" 814L, 44878C
[sy] Register new file.
[sy:git] get_diff_start()   #  <<<<<<-------- Too slow
/.repo_requirements/odoo/addons/account/models

/root/.vim
[sy:git] get_diff_git()
[sy:git] get_diff_end()
[sy:git] set_signs()
[sy:git] No changes found.
[sy:bzr] get_diff_start()
/.repo_requirements/odoo/addons/account/models

/root/.vim
[sy:bzr] get_diff_bzr()
[sy:bzr] get_diff_end()
[sy:hg] get_diff_start()
/.repo_requirements/odoo/addons/account/models

/root/.vim
[sy:hg] get_diff_hg()
[sy:hg] get_diff_end()
/.repo_requirements/odoo/addons/account/models

I saw Slow open file

I expected Faster open file

Details: Running: rgrep "get_diff_start" . --include=*.vim

The output is:

./.vim/bundle/vim-signify/autoload/sy/repo.vim:20:    call sy#repo#get_diff_start(vcs, a:do_register)
./.vim/bundle/vim-signify/autoload/sy/repo.vim:72:" Function: sy#get_diff_start {{{1
./.vim/bundle/vim-signify/autoload/sy/repo.vim:73:function! sy#repo#get_diff_start(vcs, do_register) abort
./.vim/bundle/vim-signify/autoload/sy/repo.vim:74:  call sy#verbose('get_diff_start()', a:vcs)
./.vim/bundle/vim-signify/autoload/sy.vim:77:      call sy#repo#get_diff_start(b:sy.vcs, 0)

I mean, the bundle is vim-signify

I prefer disable by default this bundle in order to open files faster.

hbto commented 7 years ago

👍

moylop260 commented 7 years ago

We had a similar issue about get a git diff from https://github.com/Vauxoo/docker-odoo-image/issues/93

The fix was a disable by default and enable from environment variable GIT_STATUS https://github.com/Vauxoo/docker-odoo-image/pull/96

We could use the same environment variable for the bundle vim-signify I mean, if GIT_STATUS==1 then enable vim-signify bundle else disable.

hugho-ad commented 7 years ago

:+1:

osvalr commented 7 years ago

:+1: on this

zaoral commented 7 years ago

+1 :+1:

jorgescalona commented 7 years ago

:+1:

JesusZapata commented 7 years ago

@moylop260 I made docker pull vauxoo/odoo-80-image-shippable-auto for download the last imagen for replicate the issue

But the vim open fast

asciicast

JesusZapata commented 7 years ago

However I did the PR to disable this functionality https://github.com/Vauxoo/docker-odoo-image/pull/208

ysantiago commented 7 years ago

:thumbsup:

moylop260 commented 7 years ago

@jesuszapata in your video you had a previous command executed then the git diff was indexed previously. But if you use the same command from scratch then you will see a opening slowest. Please review https://github.com/Vauxoo/docker-odoo-image/issues/93 where is the same case.