Vauxoo / docker-odoo-image

Base docker image for instances
GNU General Public License v2.0
18 stars 29 forks source link

Wrong application of pylint 'access-member-before-definition' #265

Closed ysantiago closed 7 years ago

ysantiago commented 7 years ago

In the image below, a misapplication of pylint access-member-before-definition is shown

skitch 206
JesusZapata commented 7 years ago

I made the follow change to skip this check access-member-before-definition

image

The check works as it should The check detect in the line 14 the use of the attribute payment_term_id but this method is defined in the line 17 We know that this is already defined but pylint only detects that file and so the chek is released

moylop260 commented 7 years ago

Eso que dices es real para cualquier método de python. Sn embargo, aquí se está usando odoo, por medio de herencia "_inherit", donde ya tiene esos campos definidos. Yo opino, que deberíamos de inhabilitar ese check para la big imagen. Ya que no aplica para odoo (el mayor número de código que escribimos es en odoo).

2017-09-08 15:25 GMT-05:00 Jesus Zapata notifications@github.com:

I made the follow change to skip this check access-member-before- definition

[image: image] https://user-images.githubusercontent.com/1387970/30229762-385b0812-94b1-11e7-9320-ea7e8aad8399.png

The check works as it should The check detect in the line 14 the use of the attribute payment_term_id but this method is defined in the line 17 We know that this is already defined but pylint only detects that file and so the chek is released

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Vauxoo/docker-odoo-image/issues/265#issuecomment-328205317, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVh29dQVL6OynQQN9Lcj8iiLcm5RBX2ks5sgaLDgaJpZM4PPRK5 .

-- Moisés López Calderón Vauxoo - OpenERP's Gold Partner Mobile: (+521) 477-752-22-30 Office: (+52) 477-773-33-46 web: http://www.vauxoo.com twitter: @vauxoo @moylop260 hangout: moylop260@vauxoo.com