search

Vauxoo / docker-odoo-image

Base docker image for instances
GNU General Public License v2.0
18 stars 29 forks source link

[FIX] odoo100, odoo110: Using wkhtmltopdf 0.12.5-1 recommended by Odoo #390

Closed moylop260 closed 3 years ago

moylop260 commented 3 years ago

More info about: 0.12.5-1: recommended for Odoo 10 and later.

luisg123v commented 3 years ago

@moylop260 isn't the installed version specified in MQT here anyway?

moylop260 commented 3 years ago

For record, I'm reproducing the current red status because of:

It is reproduced using:

root@4783e7a35fa9:/# python3.5 -m pip install git+https://github.com/vauxoo/server-tools@11.0
DEPRECATION: Python 3.5 reached the end of its life on September 13th, 2020. Please upgrade your Python as Python 3.5 is no longer maintained. pip 21.0 will drop support for Python 3.5 in January 2021. pip 21.0 will remove support for this functionality.
Collecting git+https://github.com/vauxoo/server-tools@11.0
  Cloning https://github.com/vauxoo/server-tools (to revision 11.0) to /tmp/pip-req-build-ayb1qxc8
  Running command git clone -q https://github.com/vauxoo/server-tools /tmp/pip-req-build-ayb1qxc8
  Running command git checkout -b 11.0 --track origin/11.0
  Switched to a new branch '11.0'
  Branch 11.0 set up to track remote branch 11.0 from origin.
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3.5 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-ayb1qxc8/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-ayb1qxc8/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-0228vorw
         cwd: /tmp/pip-req-build-ayb1qxc8/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/usr/lib/python3.5/tokenize.py", line 454, in open
        buffer = _builtin_open(filename, 'rb')
    FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-req-build-ayb1qxc8/setup.py'
    ----------------------------------------
WARNING: Discarding git+https://github.com/vauxoo/server-tools@11.0. Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

UPDATED:

. /usr/share/vx-docker-internal/ubuntu-base/library.sh
. /usr/share/vx-docker-internal/odoo110/library.sh
. /etc/lsb-release
PIP_OPTS="--upgrade \
          --no-cache-dir"

collect_pip_dependencies "git+https://github.com/vauxoo/odoo@11.0 \
    git+https://github.com/vauxoo/server-tools@11.0 \
    git+https://github.com/vauxoo/addons-vauxoo@11.0 \
    git+https://github.com/vauxoo/pylint-odoo@master" \
    "reqgen requirements-parser \
    git+https://github.com/vauxoo/pylint-odoo@master#egg=pylint-odoo \
    git+https://github.com/vauxoo/panama-dv@master#egg=ruc \
    sphinxcontrib-youtube" "/usr/share/vx-docker-internal/odoo110/11.0-full_requirements.txt"

No error reproduced

Adding verbose

git clone https://github.com/vauxoo/server-tools --depth 1 -q -b 11.0 /tmp/tmp.b7xftqnjeD/server-tools
git clone https://github.com/vauxoo/addons-vauxoo --depth 1 -q -b 11.0 /tmp/tmp.b7xftqnjeD/addons-vauxoo
git clone https://github.com/vauxoo/pylint-odoo --depth 1 -q -b master /tmp/tmp.b7xftqnjeD/pylint-odoo
git clone --depth -q -b 8.0 /tmp/tmp.b7xftqnjeD/1
fatal: repository '/tmp/tmp.b7xftqnjeD/1' does not exist
belisac commented 3 years ago

Hello @moylop260

Good to know that the information helps, but I haven't test it functionally, you could have my +1 and If it works! let me know!

Thanks in advance!

moylop260 commented 3 years ago

@ruiztulio

I just added echo command to enable verbose output and running:

The error is reproduced.

I just set the variable using only one repository: ODOO_DEPENDENCIES="git+https://github.com/vauxoo/server-tools@11.0"

And the output is:

git clone https://github.com/vauxoo/server-tools --depth 1 -q -b 11.0 /tmp/tmp.TkdnQziNdY/server-tools
git clone --depth -q -b 8.0 /tmp/tmp.TkdnQziNdY/1
fatal: repository '/tmp/tmp.TkdnQziNdY/1' does not exist

If I use ODOO_DEPENDENCIES="" there is not an error.

Do you have any clue about to fix it?

ruiztulio commented 3 years ago

@moylop260 if I have to gues (I haven't tested it yet) the issue is here, when these lines, they parse the oca_dependencies.txt file and they expect the old syntax (url name) and they get only the name instead.

It is not failing in the 12, 13 neither 14 because we removed this because we noticed it took a little more time to calculate the changes than we saved pre-installing them

moylop260 commented 3 years ago

@ruiztulio

Thank you!

So, I just fixed removing them too

Could you check if you are agree, please?

moylop260 commented 3 years ago

I have created the tag to revert using old image before this change if something is wrong:

I have sent the email called: wkhtmltopdf actualizada a 0.12.5-1 (antes 0.12.4) para odoo 10.0 y 11.0

So, I merged