Vauxoo / docker-ssh

Ssh server
0 stars 6 forks source link

[FIX] entrypoint.sh: Update the apt.get before the install command #5

Closed JesusZapata closed 7 years ago

JesusZapata commented 7 years ago

Before the apt-get install now it runs the apt-get update

I build this imagen using the follow command docker build -t docker-ssh . and the build ran well

image

Fix https://github.com/Vauxoo/docker-ssh/issues/4

JesusZapata commented 7 years ago

@ruiztulio What do you think about that change ?

ruiztulio commented 7 years ago

@JesusZapata This don't fix the issue, we need to install git and the needed dependencies during the build process because the problem is that the containers have limited internet acess and those packages can't be installed after the container is deployed

gurneyalex commented 7 years ago

Hello @JesusZapata @ruiztulio

why do you have the entry point running installs? This feels really wrong to me. The entrypoint should run the ssh server but in no case install anything. using the SSH_DEPENDENCIES environment variable sounds like an abuse. Why are you not building another Dockerfile FROM this one in which you install your own dependencies?

ruiztulio commented 7 years ago

@gurneyalex yes, it is, that's whay I'm asking hium to install the dependencies during the build process instead of the entry point

gurneyalex commented 7 years ago

ok but I don't see why git should be available in an ssh container. It does not belong there. This is something you need to take care of in the weblate composition.

JesusZapata commented 7 years ago

@ruiztulio I made the changes