Vauxoo / fb-connector

Facebook Connector with Odoo
4 stars 27 forks source link

Include archived leads to prevent error due constraint #16

Closed yaazkal closed 3 years ago

yaazkal commented 3 years ago

Apparently the search method only gives a match if the lead is active. But if some lead has been mark as lost or archived it does not match so it will try to create a lead and of course produce an error that will stop the lead processing.

hugho-ad commented 3 years ago

@hbto pls merge

yaazkal commented 3 years ago

this was masking another issue... it gets in an infinite loop because of https://github.com/Vauxoo/fb-connector/blob/56d947512728b6b5d68943f7e4fd82148f5e1f2a/crm_facebook_leads/models/lead.py#L260

@hugho-ad Do you want me to create a new PR using recursion for that method (lead_processing) as in a previous version?

yaazkal commented 3 years ago

@hugho-ad forget it, found an easier solution, few minutes and another PR will arrive.