Vauxoo / maintainer-quality-tools

QA tools for Odoo maintainers
GNU Affero General Public License v3.0
3 stars 9 forks source link

Pulling wrong repos when adding a oca dependency for a owner different from vauxoo #215

Closed zaoral closed 2 years ago

zaoral commented 7 years ago

I added stock-logistic-warehouse repository to the oca_dependencies of a private customer project in Vauxoo as is shows in the next image

image

As you can see I added stock-logistic-warehouse repository as OCA owner instead of Vauxoo, this because in that moment the Vauxoo repository does not have 10.0 branch (this change... now vauxoo has oca/10.0 repo forks updated). Thanks to this last state I found out the next error in runbot and travis

image

It checked oca/10.0 oca_dependencies file and I found out that the oca_dependencies does not contain the remote information https://github.com/OCA/stock-logistics-warehouse/blob/10.0/oca_dependencies.txt image

I think that maybe this lack of remote info in the oca_dependencies file is making that mqt scripts take the main project owner, instead the dependency owner: the correct owner/repos are not the ones that are pulled with mqt. Thanks to this we would have a not properly configured environment.

zaoral commented 7 years ago

cc @JesusZapata @moylop260

moylop260 commented 7 years ago

@tomeyro Could you consider this case for MQT is very similar to https://git.vauxoo.com/vauxoo/deployv/issues/204?

And migrate the fix of deployv https://git.vauxoo.com/vauxoo/deployv/issues/204 to MQT please

zaoral commented 7 years ago

Hi @tomeyro The fix related to this issues has been applied?

tomeyro commented 7 years ago

@zaoral The PR (https://github.com/Vauxoo/maintainer-quality-tools/pull/216) is still being reviewed. It should be merged soon. I'll check on it.

zaoral commented 7 years ago

@tomeyro ok. thank you @tomeyro

luisg123v commented 2 years ago

Already solved by adding variable TRAVIS_REPO_SLUG to the project template, so closing.