search

Vauxoo / maintainer-quality-tools

QA tools for Odoo maintainers
GNU Affero General Public License v3.0
3 stars 9 forks source link

[REF] travis_gitlab_translate_env: Migrate from bash to Python #285

Closed luisg123v closed 6 years ago

luisg123v commented 6 years ago

In order to minimize changes in projects's .gitlab-ci.yml files, this migrates the script travis_gitlab_translate_env from bash to Python, and runs it directly from travis_run_tests.

This Way, there is no need to source the script manually on every project's .gitlab-ci.yml, because travis_run_tests is already executed on every project.

Dummy MR: https://git.vauxoo.com/vauxoo/xunnel-account/merge_requests/53

moylop260 commented 6 years ago

Could you create a dummy in order to see that is working?

luisg123v commented 6 years ago

@moylop260 Here is the dummy:
https://git.vauxoo.com/vauxoo/xunnel-account/merge_requests/53 If it works, it should fail, triggering the lints reported on https://github.com/Vauxoo/pylint-odoo/issues/152

luisg123v commented 6 years ago

@moylop260
This is ready for review.

The dummy MR is failing, but all errors are expected. Unittests pass and some lints are triggered, as they should.