Changed modules are lint-tested even if they're on $EXCLUDE_LINT

[JonathanOsAlc]

When the test lint is running, the module shopify_ept isn't ignored and that module was specified to be ignored.

[tomeyro]

@moylop260 @luisg123v Could you help us with this?

After the latest fixes the Amazon module stopped raising errors,
but then after updating some things in the shopify module it started
raising this errors even when it shows that is ignoring the module.

[luisg123v]

@tomeyro Please provide a link to the MR where the error is reproduced.

[tomeyro]

@luisg123v https://git.vauxoo.com/vauxoo/qualifirst/merge_requests/311

[luisg123v]

Also take into account that, even if you ignore a module, when you change it in a MR, lints will be shown for that module. That's because modified modules are always lint-checked.

[tomeyro]

@luisg123v Then what is the point of ignoring it?

The mentioned module was provided and is maintained by a third party,
if the third party makes a fix (or we make a quick fix for it) the module will
be shown as "modified". We still need the module to be ignored after this,
the code base is still theirs and they don't work with our standards.

[luisg123v]

@tomeyro
I reviewed the above MR and it's the case I explained above. The module shopify_ept is being modified, and all errors come from that module:

Found 1516 errors in modules changed

Once you merge that MR, errors will disappear.

[luisg123v]

@tomeyro
I understand, but that's how it works. I agree with you, but maybe that's a topic for another issue.

It would worth to check whether OCA's MQT works the same way, I believe so.

[tomeyro]

@luisg123v Ok, I'll merge with the errors. But I still think it makes no
sense, especially when the flake tests ignore the module correctly.

[luisg123v]

@JonathanOsAlc
Could you change the title? To:
Changed modules are lint-tested even if they're on $EXCLUDE_LINT