search

Vauxoo / maintainer-quality-tools

QA tools for Odoo maintainers
GNU Affero General Public License v3.0
3 stars 9 forks source link

[FIX] test_server: Ignore trailing spaces on log messages #296

Closed luisg123v closed 6 years ago

luisg123v commented 6 years ago

Odoo recently introduced a change in the way logs are printed, adding performance information when logging HTTP requests: https://github.com/odoo/odoo/commit/c44fe912329e2d4c7541ed810526d4a069f930c4#diff-d301b3dd399c26a7f38fb31c9e1dfbddR136

However, that causes all messages who don't containg such information to contain a trailing whitespace, which causes the message "Modules loaded." to not be found.

This commit improves the regexp used to match messages in logs, to not take into account trailing whitespaces.

This also improves the error message so it's clearer.

Dummy MR: https://git.vauxoo.com/absa/absa/merge_requests/16

luisg123v commented 6 years ago

@moylop260
Could you review and merge this, please?

CC @dsabrinarg

moylop260 commented 6 years ago

Could you create the PR to OCA without change the output message?