[FIX] "Segmentation fault (core dumped)"

[moylop260]

numpy has the following issue:

• https://github.com/numpy/numpy/issues/13059

It is a corner case using a kind of processor, using docker and using python3

But who is using numpy?

There are different projects using libraries that depends of numpy: ./web/requirements.txt:2:bokeh==1.1.0 ./reporting-engine/requirements.txt:1:altair ./icm/requirements.txt:1:pandas ./maintainer-quality-tools/requirements.txt:7:websocket-client

So, I run odoo-bin with loglevel=debug to know what is the last line before to crash.

It was the path:

• Last logging https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/odoo/modules/loading.py#L152
• Using pdb I have trace the following line https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/odoo/modules/module.py#L368
• The last module imported was resource https://github.com/odoo/odoo/tree/92ef3b2dd4655913198d10d06598b799fdcae6d0/addons/resource
• I removed all imports and I reproduced the error again and again because one change fixed the issue It was when I commented the following import: https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/addons/resource/tests/common.py#L4
• I started to debug in this file line by line, so finally I found the problematic import: https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/odoo/tests/common.py#L50
  • But now what is the reason this is raising the error. It is because the following line: https://github.com/websocket-client/websocket-client/blob/29c15714ac9f5272e1adefc9c99b83420b409f63/websocket/_abnf.py#L34 is importing numpy if you are using python3 numpy is installed because of the requirements.txt files above and the disaster was did.

We can remove all numpy requirements but there are a lot of them. Or we can avoid import the websocket line that import numpy (faster solution) non-installing websocket-client, so the following line is not executed:

• https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/odoo/tests/common.py#L50

Now, I will go to sleep! :)

NOTE: It is just a summary since that I'm not talking about how I detected the libraries using numpy :)

[moylop260]

@luisg123v I think you can force push in the stable branch to revert the following one:

• https://github.com/Vauxoo/account-financial-tools/pull/19

Since that I found the real imposter!

[luisg123v]

@moylop260 done, branch was force-pushed and now it's like that PR never existed.

CC @hbto

BTW, what an outstanding debugging job!