search

Vauxoo / maintainer-quality-tools

QA tools for Odoo maintainers
GNU Affero General Public License v3.0
3 stars 9 forks source link

[FIX] travis: apply patch for duplicate-code issue for any pylint version #318

Closed fernandahf closed 3 years ago

fernandahf commented 3 years ago

Description of the issue/feature this PR addresses:

The duplicate-code (R0801) can't be disabled More information: https://github.com/PyCQA/pylint/issues/214

Current behavior before PR: duplicated-code check can't be disabled.

Desired behavior after PR is merged: duplicated-code check can be disabled.

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

fernandahf commented 3 years ago

@moylop260

Could you review this, please?

Regards.

moylop260 commented 3 years ago

Could you make a PR dummy in order to test this one, please?

moylop260 commented 3 years ago

FYI I have created a t2d using this dev branch

And the original patch is outdated since that it is failing applying the first hunk

added 8 packages from 7 contributors, removed 5 packages and updated 21 packages in 15.757s
python -c "from __future__ import print_function; from pylint.checkers import similar; print(similar.__file__.rstrip('c'))"
patching file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py
Hunk #1 FAILED at 46.
Hunk #2 succeeded at 64 (offset 4 lines).
Hunk #3 succeeded at 157 with fuzz 1 (offset 4 lines).
Hunk #4 succeeded at 178 with fuzz 1 (offset 4 lines).
Hunk #5 succeeded at 214 (offset 4 lines).
Hunk #6 succeeded at 377 (offset 4 lines).
1 out of 6 hunks FAILED -- saving rejects to file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py.rej

Could you overwrite the patch with an updated one, please?

moylop260 commented 3 years ago

We should be able to fix the following versions:

fernandahf commented 3 years ago

FYI I have created a t2d using this dev branch

And the original patch is outdated since that it is failing applying the first hunk

added 8 packages from 7 contributors, removed 5 packages and updated 21 packages in 15.757s
python -c "from __future__ import print_function; from pylint.checkers import similar; print(similar.__file__.rstrip('c'))"
patching file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py
Hunk #1 FAILED at 46.
Hunk #2 succeeded at 64 (offset 4 lines).
Hunk #3 succeeded at 157 with fuzz 1 (offset 4 lines).
Hunk #4 succeeded at 178 with fuzz 1 (offset 4 lines).
Hunk #5 succeeded at 214 (offset 4 lines).
Hunk #6 succeeded at 377 (offset 4 lines).
1 out of 6 hunks FAILED -- saving rejects to file /.repo_requirements/virtualenv/python3.6/lib/python3.6/site-packages/pylint/checkers/similar.py.rej

Could you overwrite the patch with an updated one, please?

Done

moylop260 commented 3 years ago

Could you make a dummy PR using this branch and using python2.7 and another using python3.6, please?