[REV] revert "Segmentation fault (core dumped)"

[fernandahf]

Description of the issue/feature this PR addresses:

The reason of websocket-client was deactivated is:

numpy has the following issue:

• https://github.com/numpy/numpy/issues/13059

It is a corner case using a kind of processor, using docker and using python3

More info about:

• https://github.com/numpy/numpy/issues/17674
• https://github.com/numpy/numpy/pull/17759

But who is using numpy?

There are different projects using libraries that depends of numpy: ./web/requirements.txt:2:bokeh==1.1.0 ./reporting-engine/requirements.txt:1:altair ./icm/requirements.txt:1:pandas ./maintainer-quality-tools/requirements.txt:7:websocket-client

So, if we run odoo-bin with loglevel=debug to know what is the last line before to crash.

It was the path:

• Last logging https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/odoo/modules/loading.py#L152
• Using pdb I have trace the following line https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/odoo/modules/module.py#L368
• The last module imported was resource https://github.com/odoo/odoo/tree/92ef3b2dd4655913198d10d06598b799fdcae6d0/addons/resource
• I removed all imports and I reproduced the error again and again because one change fixed the issue It was when I commented the following import: https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/addons/resource/tests/common.py#L4
• I started to debug in this file line by line, so finally I found the problematic import: https://github.com/odoo/odoo/blob/92ef3b2dd4655913198d10d06598b799fdcae6d0/odoo/tests/common.py#L50
  • But now what is the reason this is raising the error. It is because the following line: https://github.com/websocket-client/websocket-client/blob/29c15714ac9f5272e1adefc9c99b83420b409f63/websocket/_abnf.py#L34 is importing numpy if you are using python3 numpy is installed because of the requirements.txt files above and the disaster was did.

We could have removed all numpy requirements but there are a lot of them. So we decided that better option was avoid to import the websocket line that import numpy (faster solution) non-installing websocket-client.

However, after researching, we found that:

OpenBLAS creates a number of threads equal to the number of core threads available, so it quickly reached limit_memory_hard and the process was killed (SIGSEGV) Forcing OPENBLAS_NUM_THREADS=1 fixed the issue.

After test building an image to reproduce the error and using that environment variable and it was fixed.

That change was applied in following PRs:

• https://github.com/Vauxoo/docker-ubuntu-base/pull/89
• https://github.com/Vauxoo/docker-ubuntu-base/pull/90

With change applied in docker-ubuntu-base, it's not neccesary avoid to import websocket-client (allow JS tests work again), we are covered with env var OPENBLAS_NUM_THREADS.

Current behavior before PR: websocket-client is not installed by default, avoid that JS tests don't work, at least module is explicitly installed in CI.

Desired behavior after PR is merged: websocket-client is installed by default, JS tests work again without other action required.

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[fernandahf]

@moylop260

Could you review this, please?

Regards.

[moylop260]

👍

[moylop260]

@fernandahf

Could you send an email to desarrollo please?

[fernandahf]

@moylop260

Done, with this thread: Fix para error de numpy en las imágenes usadas en CI, CD y runbot

Regards.