Vauxoo / maintainer-quality-tools

QA tools for Odoo maintainers
GNU Affero General Public License v3.0
3 stars 9 forks source link

[FIX] travis_install_nightly: Chrome dev tools updated for new JS syntax t#60040 #360

Closed CarmenMiranda closed 2 years ago

CarmenMiranda commented 2 years ago

T#60040

We want to have the latest version of the chrome dev tools, used to execute the headless browser where the Javascript tests are run.

Before this commit, this version is installed: HeadlessChrome/65.0.3325.181

Causing some errors when using new Javascript syntax, like this one:

UncaughtSyntaxError: Unexpected token .
odoo.tests.common.ChromeBrowserException: UncaughtSyntaxError: Unexpected token {

After this commit, we will have the latest always fetched from google repositories.

This was based on a workaround implemented by Javier Vega javier@vauxoo.com

moylop260 commented 2 years ago

Thanks for your PR Carmen

Could you test it with a dummy and share the link of the MR, please?

Using a repository <13.0 and another one >=13.0, please?

CarmenMiranda commented 2 years ago

Title:

  • [FIX] travis_install_nightly: ...
  • Lowercase title's short description (guidelines). You may consider this a nitpick, but all Odoo commits are that way and I even have seen Odoo people correcting that.

The name was fixed, I just left the uppercase in the cases like Chrome and JS because they are proper nouns

CarmenMiranda commented 2 years ago

Thanks for your PR Carmen

Could you test it with a dummy and share the link of the MR, please?

Using a repository <13.0 and another one >=13.0, please?

@moylop260 Here is the dummy in >=13.0, It was green but I click in retry to include the changes that @luisg123v asked me for https://git.vauxoo.com/vauxoo/instance/-/merge_requests/1377

I will pass to you the dummy in <13.0 when I'm done with a meeting 🙈

CarmenMiranda commented 2 years ago

Hi, @luisg123v @moylop260 This is the dummy in version < 13.0

https://git.vauxoo.com/absa/absa/-/merge_requests/2498

luisg123v commented 2 years ago

The related issue is affecting several projects and the proposed fix is working under several versions, so merging.