Vauxoo / odoo-panama

Odoo Localization Panama
4 stars 9 forks source link

l10n_pa_localization, vat_partitioned: Move vat field from page Accounting to address section of res_partner #35

Closed ysantiago closed 8 years ago

ysantiago commented 8 years ago

TASK#5682

moylop260 commented 8 years ago

@nhomar A replace of view could make us errors in other inherited views. What do you think about use a extra related field?

NOTE: I don't know if a sequence very high could be the work.

ysantiago commented 8 years ago

@JulioSerna here the changes, your opinion is important.

JulioSerna commented 8 years ago

if we are continue working with the address_format concept is the way that we can modify the part of view address_format

in fact, it is the current behavior in Odoo, the address_format is render by the address_format of the company and then if you can modify this section of view you need to modify by code python because with inhertit view xml does not work

ysantiago commented 8 years ago

@moylop260 This is the way we can add this field in that part of the view because it doesn't work with inherit view

moylop260 commented 8 years ago

We should let the project of localisation as clean as posible. If you require a position="replace" to satisfied a customer request then you should use the customer project. And we could avoid errors of other project that use odoo-panama with ...<xpath expr="//field[@name='vat']" position="after"> <field name="my_new_field"/>... because your <xpath expr="//field[@name='vat']" position="replace"> deletes the field and won't found it.

ysantiago commented 8 years ago

The error occurs if the view with ...<xpath expr="//field[@name='vat']" position="after"> <field name="new_field"/>... has a priority equal or lower than view with ...<xpath expr="//field[@name='vat']" position="replace">.

Therefore, it is assigned a low priority to the view that makes the replace: res_partner_view.xml

ysantiago commented 8 years ago

Hello @moylop260

The place where the VAT field is going to move is pending to be defined, this PR can be closed.

gquilarque commented 8 years ago

Hi,

@ysantiago and @moylop260 this feature will by solve by @josemoralesp in this Task#5700, Point#5

@josemoralesp you can review this PR for check the proposed changes by @ysantiago and the comments made by @moylop260

Thanks @ysantiago and @moylop260 for your support. 🎱