First review

[moylop260]

Lint

• [x] Use pre-commit-vauxoo instead of pre-commit - Fixed from https://github.com/Vauxoo/odoo-selenium/pull/10
• [x] Define tox -e lint to run pre-commit-vauxoo - Fixed from https://github.com/Vauxoo/odoo-selenium/pull/10

Unittest

• [x] Run docker tests with odoo@14.0, odoo@15.0 & odoo@16.0 - Fixed from https://github.com/Vauxoo/odoo-selenium/pull/2
• [x] #11

Packaging

• [x] Define package pypi configuration files
• [x] Define what python version are compatibles from the configuration files
• [x] Define a pipeline to publish to pypi (only released/tagged signed) Fixed from https://github.com/Vauxoo/odoo-selenium/pull/8
• [x] Add requirements.txt with selenium package required to work
• [x] Implement bump2version fixed from https://github.com/Vauxoo/odoo-selenium/pull/8
• [x] Implement tox -e build to build the package fixed from https://github.com/Vauxoo/odoo-selenium/pull/8

Project configuration

• [x] Use the same gitignore as our project-template fixed from https://github.com/Vauxoo/odoo-selenium/pull/8
• [x] Change the name of the package to odoo-selenium and the folder name src/odoo_selenium (ask to the team to vote what name is better) - Fixed from https://github.com/Vauxoo/odoo-selenium/pull/4

README

• [x] Add what odoo versions are compatible (as you are using new py syntax it is not compatible with odoo@12.0 and so on) fixed from https://github.com/Vauxoo/odoo-selenium/commit/d9d4b7bc361ee49ebe07901ce9f1811da37c5aec
• [x] Add badges similar to https://github.com/Vauxoo/pre-commit-vauxoo#overview fixed from https://github.com/Vauxoo/odoo-selenium/commit/d9d4b7bc361ee49ebe07901ce9f1811da37c5aec

[antonag32]

About the packaging, it uses flit and the information is in pyproject.toml. I tried to make it this package more "modern", it is related to PEP 517 and other concepts. I think the only stuff missing would be things like LICENSE, author, and classifier information, and the pipeline.

[antonag32]

Regarding lints, since this project is using pyproject.toml, pre-commit-vauxoo breaks it. I opened an issue about it: https://github.com/Vauxoo/pre-commit-vauxoo/issues/118

Should not be too hard to fix it.

[moylop260]

Regarding lints, since this project is using pyproject.toml, pre-commit-vauxoo breaks it. I opened an issue about it: Vauxoo/pre-commit-vauxoo#118

Should not be too hard to fix it.

Replied in the another issue

Summary: No problem overwritting the file

[moylop260]

FYI I have updated some items in the description of this issue

[moylop260]

@antonag32

I think we will need to rename the packaga again 😢

I just ran the following commands:

python3 -m build --sdist --wheel --outdir dist/ && \
  python3 -m twine check --strict dist/* && \
  python3 -m twine upload --verbose --repository-url https://upload.pypi.org/legacy/ dist/*

And the ouput was:

• 400 The name 'odoo-selenium' is too similar to an existing project. See https://pypi.org/help/#project-name for more information.

It looks because of the following project:

• https://github.com/meta-it/odooselenium
  • https://pypi.org/project/odooselenium/

[antonag32]

Dangit, I am biased because I came up with, but osut is a pretty weird name, I don't think anyone else is using it. It also follows PEP recommendations (AFAIK):

https://peps.python.org/pep-0008/#package-and-module-names

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.

When an extension module written in C or C++ has an accompanying Python module that provides a higher level (e.g. more object oriented) interface, the C/C++ module has a leading underscore (e.g. _socket).

[moylop260]

FYI I have added bump2version, build and publish packages from:

• https://github.com/Vauxoo/odoo-selenium/pull/8

The following version was uploaded using this way:

• https://pypi.org/project/odoo-selenium-httpcase/0.1.1/
  • 

Steps to publish:

bump2version patch
git push stb main --tags

[moylop260]

Almost of bullet point were fixed

Only one extra point is pending so creating a separated issue only with coverage matter