search

Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[FIX] base: strict=False when create new object PdfFileReader #233

Closed JesusZapata closed 7 years ago

JesusZapata commented 7 years ago

Current behavior before PR: Actually the branch saas-17 show the follow warning http://runbot.odoo.com/runbot/build/250255

2017-07-31 17:18:35,300 29183 WARNING 250255-saas-17-391a29-all py.warnings: /usr/local/lib/python2.7/dist-packages/PyPDF2/pdf.py:1736: PdfReadWarning: Xref table not zero-indexed. ID numbers for objects will be corrected.
  warnings.warn("Xref table not zero-indexed. ID numbers for objects will be corrected.", utils.PdfReadWarning)

I found some help about this WARNING https://github.com/mstamy2/PyPDF2/issues/36#issuecomment-28843088

Desired behavior after PR is merged: No found WARNING in the odoo log

What is the impact of that change ?

Related with https://github.com/odoo/odoo/pull/18582

JesusZapata commented 7 years ago

@moylop260 What do you think about this solution ? Is only a small change.

nhomar commented 7 years ago

this is solvd already, this was a crossed error.

nhomar commented 7 years ago

close odoo's one please