search

Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[REF] l10n_mx: using code instaed color in onchange t#8500 #234

Closed goliveirab closed 6 years ago

goliveirab commented 7 years ago

Isuue: https://github.com/Vauxoo/mexico/issues/772 Avoiding use of 'color' field to change the tags.

Result

goliveirab commented 7 years ago

@luistorresm @moylop260 could you please check this..

goliveirab commented 7 years ago

@moylop260 Any news/changes about this?

moylop260 commented 7 years ago

Could you remember the rational of this change, please?

goliveirab commented 7 years ago

The main purpouse here is to avoid using the field 'color' to filter de tags.

moylop260 commented 7 years ago

Yes, the main description has that sentence. But the why?

goliveirab commented 7 years ago

The filter of the tags is made based in the color field, if the color changes then the method could not work as expected, so avoiding the use of that field may avoid that.

moylop260 commented 7 years ago

Could you fix the conflicts, please?

moylop260 commented 7 years ago

@nhomar Do you define the previous version of this feature, We need your approval here, please

luistorresm commented 7 years ago

@goliveirab

Could you make a update of this branch, please?

goliveirab commented 7 years ago

@moylop260 could you please check it. @luistorresm

goliveirab commented 7 years ago

Is there any changes or request about this? @moylop260 @luistorresm

moylop260 commented 7 years ago

@goliveirab I'm waiting @nhomar approval from https://github.com/Vauxoo/odoo/pull/234#issuecomment-326361522

luistorresm commented 6 years ago

@moylop260

This PR has around of 8 months, and We do not have this problem.

You think that We could close it?

Regards