Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[11.0] Avoid press too many times at same time a button. #274

Closed moylop260 closed 6 years ago

moylop260 commented 6 years ago

Fix big performance issue:

Commit: https://github.com/odoo/odoo/commit/39f0895 https://github.com/odoo/odoo/commit/37db390

Avoid press too many times at same time a button.

hugho-ad commented 6 years ago

Is it not possible to request forward port those commits at Odoo/Odoo?

moylop260 commented 6 years ago

For the record, They told us that is not possible fowardport it to 11.0

But Hugo have created the following issue for 11.5 https://github.com/odoo/odoo/issues/26945

hugho-ad commented 6 years ago

@moylop260 FYI https://github.com/odoo/odoo/issues/26945#event-1859598504 was solved and it works for the scenario that I reported

Regards!

moylop260 commented 6 years ago

Excellent! Thanks! could you backported to 11.0 please? And try it reproduce it? Use my current opened pr -- Moisés López Calderón Mobile: (+521) 477-752-22-30 Twitter: @moylop260 hangout: moylop260@vauxoo.com http://www.vauxoo.com - Odoo Gold Partner Twitter: @vauxoo

hugho-ad commented 6 years ago

The fix landed at Odoo/enterprise v11.0 https://github.com/odoo/enterprise/commit/762d8235a8cfa5153270f439b899fbdf6d2ec745

hugho-ad commented 6 years ago

@moylop260

I tried to replicate it but apparently was solved since I was not able to replicate it. see the following video https://youtu.be/VWuTrrIi6K8

Regards!

hugho-ad commented 6 years ago

@moylop260

I made that you told me,

I inherited the read method instead of the search_read, because the search_read never was called, then I set a sleep at confirm_sale and the read, but the system never got block https://drive.google.com/open?id=1F3DT1zIVNmPobHX2eCx1cvLvQV9OrxEX

Regards!

moylop260 commented 6 years ago

Ok, let's to closed it for now If in the future we can reproduce it using other way we will be back here.