search

Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[IMP] base: avoid hard-code the rate precision #277

Closed alxolivares closed 5 years ago

alxolivares commented 5 years ago

Description of the issue/feature this PR addresses: This change allows us to inherit the precision of the rate in a more cleaner way in the future.

Current behaviour before PR: Using the banxico rate value of 20.4108, when dividing 1/20.4108 we get 0.048993.

Desired behaviour after PR is merged: The expected value must be 0.048993670017

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

alxolivares commented 5 years ago

@yaniaular, Could you check the description? Regards

hugho-ad commented 5 years ago

why do you not submit this to Odoo/odoo?

yaniaular commented 5 years ago

@hugho-ad To get feedback in vauxoo before to submit in odoo

moylop260 commented 5 years ago

Please, create the PR to odoo

moylop260 commented 5 years ago

@alxolivares Could you add the URL of the PR to odoo here, plase?

alxolivares commented 5 years ago

@moylop260 Done! https://github.com/odoo/odoo/pull/29950