search

Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[IMP] l10n_pe, base_vat: improve interaction with l10n_latam* #324

Closed umiphos closed 3 years ago

umiphos commented 5 years ago

Description of the issue/feature this PR addresses:

First, l10n_pe does not need to have base_vat, we are adding the dependency l10n_latam_base, there is the dependency of base_vat.

Second, base_vat does not need to check the structure and letters of the VAT because we are already adding a field for the type of document in l10n_latam_base(l10n_latam_identification_type_id), this field does what the logic in the module did before.

Now, all the future developments should only use the VAT and l10n_latam_identification_type_id and not split_vat, that method is no longer useful is we use the latam modules.

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

umiphos commented 5 years ago

@nhomar this is the change for the base_vat working with l10n_latam_invoice_documents