[FIX] website_sale: Bigger priority to prevent errors in views

Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo

https://www.odoo.com

Other

9 stars 9 forks source link

[FIX] website_sale: Bigger priority to prevent errors in views #503

Closed sebasdrk17 closed 2 years ago

sebasdrk17 commented 2 years ago

Bigger priority to prevent crashing xpaths (I don't think this is needed, testing the case)

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

luisg123v commented 2 years ago

I don't think a patch is needed for this:

This view doesn't have any replace
Even if needed, priority could be modified from any other module

sebasdrk17 commented 2 years ago

I'm just testing the view and see if the problem relies on just the order of the views

I also think that this patch should not be needed just for a lint (I'm not aware of all the inconvenient that not specifying a priority should create)

But since the priority of the view l10n_mx_website_sale.address changed its priority to "100", this view needs to be after that view, that's why I've changed it to "200"

But if I can't use the priority, then I'll find another way and close this PR

luisg123v commented 2 years ago

Fixed in another way.