search

Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[IMP] point_of_sale, pos_coupon: using Odoo helper methods insead of backbones #509

Closed JVegaB closed 1 year ago

JVegaB commented 2 years ago

Related Odoo PR

https://github.com/odoo/odoo/pull/103215

hugho-ad commented 2 years ago

why this changes couldn't be target odoo/odoo?

I know they are improvements, but they are not breaking or introducing new behaviors

hugho-ad commented 2 years ago

@JVegaB

I leave you a comment above

JVegaB commented 2 years ago

@hugho-ad Just because we are not fixing anything. For me modifications for our convenience, goes into this repo, so the high priority pull request are managed at odoo/odoo.

If I opened a ticket at odoo/odoo, it would say something like: "Changing the lowdash method, for the Odoo one." Giving as excuse, that we have our custom implementation and we need it. So, following that reasoning, I decided to create the pull request here, at vauxoo/odoo.

hugho-ad commented 2 years ago

we can try it, at the end it's looks like an not harmful improvement

hugho-ad commented 1 year ago

Done at https://github.com/odoo/odoo/commit/9054173b386e39bfd2c5e05304a786a3ea0940f9