Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[IMP] web: Add a new parameter to know when to keep progressive format base on request context #513

Closed sebasdrk17 closed 1 year ago

sebasdrk17 commented 2 years ago

Use as a patch.

Issue

The main issue is that when the resize is made, it creates a new image, resulting in the loss of the original format, PIL allows progressive images only on JPEG files, we just need to pass the parameter in order to create a new image with this format

What changed

[IMP] odoo.tools

Desired behaviour

After this patch now the resized images keep the progressive format in their encoder info if the keep_progressive key is inside the request context

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

sebasdrk17 commented 2 years ago

Hello @moylop260 could you give me a technical review here please?

More context here

sebasdrk17 commented 2 years ago

@oscarolar patch related to MR#2530

sebasdrk17 commented 2 years ago

@moylop260 could you review again please?

oscarolar commented 1 year ago

@luisg123v what's the reason for closing this pull?

luisg123v commented 1 year ago

@oscarolar,

All branches targeting 12.0 and older were removed.

If you're using this as a patch, take into account the PRs don't need to be opened for patches to work. And since the 12.0 branch won't be updated anymore, there's no conflict risk.

If you really need this to be opened, it may be re-opened without troubles.

oscarolar commented 1 year ago

Thanks, I just needed the reason.

@luisg123v