Vauxoo / odoo

Fork of Odoo (formerly OpenERP). [This project is not publically mantained just born for internal usage with some little patches] go to official repository on github.com/odoo/odoo
https://www.odoo.com
Other
9 stars 9 forks source link

[REF] pos_gift_card: Gift Card split by taxes #555

Open CarmenMiranda opened 1 year ago

CarmenMiranda commented 1 year ago

Allow splitting a gift card when 2 or more products with different taxes are in the same order, so each group of taxes has a line with the Gift Card assigned with the corresponding taxes.

For that, the validation of using the same gift card in the order "This gift card is already applied" was removed to allow the creation of multiple lines with the same gift card at the same time, but the gift card will only be used once by the order since when is used a second time the previous lines will be removed.

Also, the computing of the balance in the gift card was fixed to allow using the price_subtotal_incl instead of price_unit since when a tax without the option "Included in Price" (price_include) set as True the balance was not being calculated taking into account those taxes.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

JVegaB commented 1 year ago

This one LGTM