search

Vauxoo / pre-commit-vauxoo

pre-commit-vauxoo python library to add a command to use all the configuration files and environment variables of Vauxoo
Other
2 stars 2 forks source link

[REF] cfg: bump pylint-odoo to v9.0.4 #127

Closed antonag32 closed 11 months ago

antonag32 commented 1 year ago

pylint v3.0.0 was released and pylint-odoo has been updated to work with it. A new major version of pylint-odoo has therefore been released.

BREAKING CHANGE: support for python < 3.7 (everything below py3.8) has been dropped since pylint no longer supports it upstream either.

moylop260 commented 1 year ago

We need to support the old pylint-odoo in order to support oldest Odoo version

I mean, Odoo<=13.0 using the current files Odoo>=14.0 using the new files

Or maybe we could use an extra command for old version of Odoo

I mean, pinning pre-commit-vauxoo package from .gitlab-ci.yaml

We need to enforce enabling the new checks only for newest Odoo's version

What do you think @luisg123v ?

moylop260 commented 1 year ago

I think we could take advantage (different commit) to update all the other packages too

antonag32 commented 1 year ago

I think we could take advantage (different commit) to update all the other packages too

Yes good idea, I will review that

antonag32 commented 1 year ago

We need to support the old pylint-odoo in order to support oldest Odoo version

I mean, Odoo<=13.0 using the current files Odoo>=14.0 using the new files

Or maybe we could use an extra command for old version of Odoo

I mean, pinning pre-commit-vauxoo package from .gitlab-ci.yaml

We need to enforce enabling the new checks only for newest Odoo's version

What do you think @luisg123v ?

Pylint can still lint python3.7 code, it just can't run on Python 3.7, however that option needs to be enabled through configuration. Maybe that could work.

antonag32 commented 1 year ago

Marked as draft since this needs further planning and I also need to test it on some projects.

antonag32 commented 12 months ago

All new checks found are marked as optional, tested on some projects and mandatory checks seem unaffected. Seems good for review and merge

antonag32 commented 12 months ago

Just to be clear it could be merged, but still not released, as the mass MRs with black autofixes are not finished yet

moylop260 commented 11 months ago

LGTM

Only check if the MRs with autofixes created from the bot were already merged please

@luisg123v