Closed rolandojduartem closed 2 years ago
@rolandojduartem
I can not reproduce it
See the scss changes
modified: CHANGELOG
modified: CONTRIBUTING.md
modified: check_doc.sh
modified: post-migration-script.sql
Could you describe better the steps to reproduce it, please?
FYI I have already reproduced using the branch 14.0 sha b14bac0757807b24336930f886ba3693d3447587
After the configuration files were copied the issue is reproduced faster running the following command:
pre-commit run prettier --color=always -c .pre-commit-config-autofix.yaml --file theme_vauxoo/static/src/scss/primary_variables.scss
@rolandojduartem
Could you check if the output from https://github.com/Vauxoo/pre-commit-vauxoo/pull/19 is raising error too, please?
@moylop260 I followed this conversation in the PR FYI
I think this is because of https://github.com/prettier/prettier/issues/8855
@moylop260
The following issue happend in the recent MR where some commas like this and this were removed using pre-commit-vauxoo. Removing those commas caused this traceback which affect tour tests like this. The problem was solved putting back those commas, but if you try to execute pre-commit-vauxoo again, it will remove those commas again. This is important for the new lint to avoid reformatted issues.
Issue caused by removing commas:
Resolved putting back commas (manually):
cc @luisg123v