search

Vauxoo / pylint-conf

Este proyecto se manejará el estándar de configuración de pylint versionado
GNU Lesser General Public License v3.0
0 stars 17 forks source link

[REF] pylint.cfg: Disable ungrouped-imports #74

Closed moylop260 closed 3 years ago

moylop260 commented 3 years ago

We uses a lot "from odoo import fields;from odoo.tools import ..." so it is a valid case for us

luisg123v commented 3 years ago

@moylop260 what do you mean?

In the provided example, packages are at different levels (odoo.fields and odoo.tools.*)

moylop260 commented 3 years ago

Package is the same The package is odoo

moylop260 commented 3 years ago

Using the following code this check was raised:

from odoo.tools import mute_logger, misc
from freezegun import freeze_time
from odoo import fields

The message is not enough clear

It looks like it is waiting for only one sentence with from odoo...

But it is not it is waiting for using a newlint next to first from odoo...

It is a isort check that we will auto-fix using pre-commit in the future

But I don't think we should change all the current code manually because of this check

luisg123v commented 3 years ago

I understand. I just wanted to clarify, we wouldn't need to "change all the current code manually". By just running isort, it will be fixed automatically and recursively (I always do it before pushing)