search

Vauxoo / pylint-odoo

1 stars 4 forks source link

[FIX] Active xml-attribute-translatable if the version is 8.0 #111

Closed JesusZapata closed 7 years ago

JesusZapata commented 7 years ago

Active xml-attribute-translatable if the version is 8.0

JesusZapata commented 7 years ago

@moylop260 What do you think about this PR

moylop260 commented 7 years ago

You had a similar issue related with use a configuration parameter of a class over other one from https://github.com/Vauxoo/pylint-odoo/pull/103 Please, review your fix and the history

moylop260 commented 7 years ago

Could you create a cherry-pick for OCA https://github.com/Vauxoo/pylint-odoo/commit/a09e019b809c6f5ee17f990e15f9c413fbe846b1? And create other check for detect if there is a xml attribute translatable for versions != 8.0 where is required delete it because is not longer need it.

moylop260 commented 7 years ago

@osvalr Could you check that this feature work reverting the fixes of this case for version 10.0 that you created before, please?

osvalr commented 7 years ago

@moylop260 I will

JesusZapata commented 7 years ago

@moylop260 Done, Te oca PR is https://github.com/Vauxoo/pylint-odoo/pull/112