search

Vauxoo / pylint-odoo

1 stars 4 forks source link

[IMP] New check useless-attribute-non-translatable #113

Closed JesusZapata closed 4 years ago

JesusZapata commented 7 years ago

Referring to https://github.com/Vauxoo/pylint-odoo/pull/111#issuecomment-279280664

The xml attribute translation=off is not necessary when version is different to 8.0

JesusZapata commented 7 years ago

@moylop260 What do you think about this PR

JesusZapata commented 7 years ago

Travis is red for new pylint-odoo check dangerous-view-replace-wo-priority https://travis-ci.org/Vauxoo/pylint-odoo/jobs/257077268#L2250

JesusZapata commented 6 years ago

@moylop260 This PR now is green and now I used the odoo_check_versions to skip more easy this new check

JesusZapata commented 6 years ago

@moylop260 I made the changed proposed

luistorresm commented 6 years ago

Hello @JesusZapata @moylop260

We could make the same to this validation:

l10n_mx_facturae_base/wizard/wizard_ir_attachment_facturae_mx_supplier.py:40: [W8113(attribute-string-redundant), IrAttachmentFacturaeMxWizard] The attribute string is redundant. String parameter equal to name of variable

This is in v8.

JesusZapata commented 6 years ago

@luistorresm This check attribute-string-redundant also is necessary to the the odoo 8.0.

luisg123v commented 4 years ago

This is abandoned and has conflicts, so closing.