Closed maitaoriana closed 6 years ago
What is your real case?
NOTE: If you use tests
folder the check is skipped
@moylop260 In this PR https://github.com/Vauxoo/mexico/pull/870, i have two csv files (l10n_mx_edi.res.locality.csv, res.city.csv) and they are not uset from manifest because they are loaded from hook.
These files contain the data of the cities and localities of Mexico, do you think it is correct to move them to the tests folder?
@maitaoriana I saw the docstring of your method Import CSV data as it is faster than xml and because we can't use noupdate anymore with csv
-u module
So we need to support this case, maybe a extra folder defined for these cases...
@JesusZapata Could you help us to support a extra folder for these cases?
(I don't know what is the better name but maybe @nhomar could help us to define a folder name)
@moylop260 we can not ignore the file itself? why a folder? and remember this is how this is working on 11.0 also in all case use static folder ?
@moylop260, do you agree with adding the files into the static folder?
Maybe, we should use the folder examples
defined in our template module in order to skip these cases:
@moylop260 Any news about this? Remember this is still pending.
@moylop260 about this issue is there any progress?, is that for vauxoo/mexico 11.0, only this is needed to correct the lint. If you need something help with tests, I can support you with that.
@moylop260 I've got a couple of ideas in mint to solve this issue:
data_extra
, similar to how the translations folder is named in this module..gz
file, so the file name would be something like res.city.csv.gz
. Of course, files would need to be extracted before being imported, but (IMO) this approach is more consistent with large data files like these.What do you think?
In some cases the data of the
csv
files are loaded from a hook then it is not necessary to add it to the__manifest__.py
file.But this pylint error occurs:
[W7930 (file-not-used),] not used from manifest