search

Vauxoo / pylint-odoo

1 stars 4 forks source link

WIP: [FIX] manifest-version-format: Don't ignore valid Odoo versions #153

Closed luisg123v closed 6 years ago

luisg123v commented 6 years ago

Currently, the parameter --valid_odoo_versions is being ignored when checking a module's version in its manifest. So, for example, if the only valid version is 11.0, and any module has in its manifest 10.0.1.0.0, this lint would result in a false positive.

This commit ensures the above parameter is taken into account when checking module versions set in the manifest.

A new test case is provided for this behavior

Closes #150

luisg123v commented 6 years ago

Closing this for now, I'll re-open it when it's fixed in OCA/pylint-odoo

luisg123v commented 6 years ago

This will be addressed on https://github.com/Vauxoo/pylint-odoo/pull/156, so this won't be re-opened