search

Vauxoo / runbot-addons

Runbot Custom Features to be used by community.
GNU Affero General Public License v3.0
3 stars 7 forks source link

[FIX] runbot_travis2docker: Be more verbose when fetching SSH keys fails #176

Closed luisg123v closed 6 years ago

luisg123v commented 6 years ago

Currently, if any error occurs when fetching SSH keys of the author and committer, the printed message is bare and it's only visible in debug level:

... DEBUG runbotdb odoo.addons.runbot_travis2docker.models.runbot_build:
Error fetching author

This commits makes this error more verbose and useful, and increases its logging level to warning.

This is related to https://github.com/Vauxoo/runbot-addons/issues/173

luisg123v commented 6 years ago

@moylop260
Could you review this, please?

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 62.806% when pulling 2eddf136ca7911dd7b1a3ab6883a16a3a36e8c51 on vauxoo-dev:11.0-error_fetching_ssh_keys_verbose into 4fd10d329a97b7f3223ace34e15d0cb3459527c6 on Vauxoo:11.0.

codecov-io commented 6 years ago

Codecov Report

Merging #176 into 11.0 will decrease coverage by 0.14%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             11.0    #176      +/-   ##
=========================================
- Coverage   62.94%   62.8%   -0.15%     
=========================================
  Files          10      10              
  Lines         448     449       +1     
=========================================
  Hits          282     282              
- Misses        166     167       +1
Impacted Files Coverage Δ
runbot_travis2docker/models/runbot_build.py 79.23% <0%> (-0.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fd10d3...2eddf13. Read the comment docs.