[REF] MP4000.py: Updated sensors reading

Vauxoo / stoqdrivers

Python fiscal printer (ECF) drivers

GNU Lesser General Public License v2.1

2 stars 3 forks source link

[REF] MP4000.py: Updated sensors reading #15

Closed suniagajose closed 8 years ago

suniagajose commented 8 years ago

Simple changes after a review of sensors parameters in Bematech MP4000 Revision 1.2 Technical Manual
Changed port in test_coupon
Updated bematech mp-4000 txt files

This change is

suniagajose commented 8 years ago

Hi @nhomar,

I have understand that when some behaviour in fiscal printer has been changed the txt files for this printer must be regenerate (correct me if I'm wrong). I am following the advice that @moylop give it to me in #14

/dev/ttyUSB0 is the port were printer is actually connected

nhomar commented 8 years ago

Ok about the change on test files. But about the port, please meet with @moylop260 such port to be able to run in the remote CI can not be a /dev prot your tests must run in the filesystem without printer that's why the txt behavior.

moylop260 commented 8 years ago

@suniagajose

My comment is missing a extra step:

[x] rm -rf ./stoqdrivers/tests/data/bematech-MP4000-*.txt
[x] Set the real serial port variable
[x] Run tests again locally: make coverage
[ ] Save changes just of *.txt files: git add ./stoqdrivers/tests/data/*.txt
- [ ] Revert changes to tests/test_coupon.py file: git checkout tests/test_coupon.py

suniagajose commented 8 years ago

Revert ready! Thanks for making it clear @moylop260

nhomar commented 8 years ago

@suniagajose can you rebase this PR please.

suniagajose commented 8 years ago

Already is up to date!

up-to-date-git

moylop260 commented 8 years ago

Make a fixup of 5ed9c7524ed62a060c0c41078f1d9bf4c65af059 in da8302fc4781ead02fdd5310db0f92d00972d07a to avoid have a extra commit just for a typo.

moylop260 commented 8 years ago

More info here: Limpia tu branch con auto-squash