Vauxoo / travis2docker

This is a Library to transform travis to docker file
BSD 2-Clause "Simplified" License
13 stars 15 forks source link

[IMP] Include .vscode for autoconfiguration #170

Closed antonag32 closed 2 years ago

antonag32 commented 2 years ago

A .vscode folder is copied onto the container, this autoconfigures some things:

I mark this as draft since there are some things to consider before committing:

  1. Since this is a dev instance I am not sure there should be an Odoo service. Especially since it is more convenient to launch and stop it trough Vscode. Right now when launching from Vscode the port is already in use so that throws an error.
  2. Should we try and find out what the main module being developed is? That way we could include one more Launch Option which runs the unit tests only for the main module being developed by the repo.
  3. I personally run my tests on Vscode with the logger on ERROR level, since I don't really care about anything else when running unit tests. Should I add that by default on the "Odoo Tests" launch mode?

Also I am only use those extensions personally and don't know of any other useful setting, but perhaps some other people know cool Quality of Life stuff that could be added.

Related to https://github.com/Vauxoo/travis2docker/issues/158

codecov-commenter commented 2 years ago

Codecov Report

Base: 83.33% // Head: 83.05% // Decreases project coverage by -0.28% :warning:

Coverage data is based on head (2f79d0d) compared to base (a83d234). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #170 +/- ## ========================================== - Coverage 83.33% 83.05% -0.29% ========================================== Files 7 7 Lines 588 590 +2 Branches 101 101 ========================================== Hits 490 490 - Misses 69 71 +2 Partials 29 29 ``` | [Impacted Files](https://codecov.io/gh/Vauxoo/travis2docker/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo) | Coverage Δ | | |---|---|---| | [src/travis2docker/travis2docker.py](https://codecov.io/gh/Vauxoo/travis2docker/pull/170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo#diff-c3JjL3RyYXZpczJkb2NrZXIvdHJhdmlzMmRvY2tlci5weQ==) | `85.41% <0.00%> (-0.60%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

moylop260 commented 2 years ago

It is working as expected:

I just had that open the /home/odoo path from vscode and it proposed to install all extensions

We can work the WIP from another PRs

I would appreciate to enable lints too

But for now it is good

Let me know when it is ready to merge it, please

moylop260 commented 1 year ago

@antonag32

Could you check if this feature has something wrong since that I just tested and now it is not working, please?

antonag32 commented 1 year ago

Yes, whats not working for you? I will test it out on a clean Ubuntu VM.

moylop260 commented 1 year ago

The old video:

is not working

I think it is related to auto-install plugins so I have installed manually

But then the "odoo" path was not identified

Maybe I was doing something wrong

but call me when you can in order to show you