search

Vauxoo / travis2docker

This is a Library to transform travis to docker file
BSD 2-Clause "Simplified" License
13 stars 15 forks source link

Draft: [IMP] t2d: Lint support for vscode and extra config #171 #173

Closed antonag32 closed 1 year ago

antonag32 commented 1 year ago

Closes #171

Adds extra extensions, and also support for Pylint checks in real time. Still marked as draft since apparently pylint-odoo is not loaded correctly, since self.env.cr.commit() is not flagged.

Also need to research more into gitlens, since apparently working with self-hosted repos is only supported with a premium gitlens membership.

eslint needs to be installed for JS lints to work, so that will also need to be installed.

codecov-commenter commented 1 year ago

Codecov Report

Base: 83.05% // Head: 83.02% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (2e948e6) compared to base (8a6c87b). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #173 +/- ## ========================================== - Coverage 83.05% 83.02% -0.03% ========================================== Files 7 7 Lines 590 589 -1 Branches 101 101 ========================================== - Hits 490 489 -1 Misses 71 71 Partials 29 29 ``` | [Impacted Files](https://codecov.io/gh/Vauxoo/travis2docker/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo) | Coverage Δ | | |---|---|---| | [src/travis2docker/cli.py](https://codecov.io/gh/Vauxoo/travis2docker/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo#diff-c3JjL3RyYXZpczJkb2NrZXIvY2xpLnB5) | `75.75% <0.00%> (-0.25%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

antonag32 commented 1 year ago

Added support for eslint too, however there seems to be some bugs with the vscode extension. https://github.com/microsoft/vscode-isort/issues/77

Gitlens integration was successful, now I just need to parse the domain from the gitrepo and determine the type (gitlab or github)