Vauxoo / travis2docker

This is a Library to transform travis to docker file
BSD 2-Clause "Simplified" License
13 stars 15 forks source link

FIX: CI and consider EXCLUDE env var in deployv entrypoint #189

Closed antonag32 closed 1 year ago

antonag32 commented 1 year ago

EXCLUDE was not being taken into account when deciding which modules to install and run when using --deployv. Fixed the entrypoint to do so

codecov-commenter commented 1 year ago

Codecov Report

Base: 82.74% // Head: 82.06% // Decreases project coverage by -0.67% :warning:

Coverage data is based on head (19e41bc) compared to base (d9b5ec3). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 19e41bc differs from pull request most recent head 20748b2. Consider uploading reports for the commit 20748b2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #189 +/- ## ========================================== - Coverage 82.74% 82.06% -0.68% ========================================== Files 7 7 Lines 591 591 Branches 101 98 -3 ========================================== - Hits 489 485 -4 - Misses 73 77 +4 Partials 29 29 ``` | [Impacted Files](https://codecov.io/gh/Vauxoo/travis2docker/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo) | Coverage Δ | | |---|---|---| | [tests/test\_travis2docker.py](https://codecov.io/gh/Vauxoo/travis2docker/pull/189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo#diff-dGVzdHMvdGVzdF90cmF2aXMyZG9ja2VyLnB5) | `98.07% <100.00%> (-1.93%)` | :arrow_down: | | [src/travis2docker/travis2docker.py](https://codecov.io/gh/Vauxoo/travis2docker/pull/189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo#diff-c3JjL3RyYXZpczJkb2NrZXIvdHJhdmlzMmRvY2tlci5weQ==) | `84.13% <0.00%> (-0.69%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

antonag32 commented 1 year ago

@luisg123v @moylop260

I think it is ready. I placed the two commits (fix exclude and fix ci) in a single PR since I thought it was easier to merge this way.