Vauxoo / travis2docker

This is a Library to transform travis to docker file
BSD 2-Clause "Simplified" License
13 stars 15 forks source link

Fallback to --deployv when travis.yml is not found and variables.sh exists #191

Closed antonag32 closed 1 year ago

antonag32 commented 1 year ago

Fixes #188.

Usage of travis.yml to create docker containers is being deprecated in favor of directly creating containers from their deployv image, this can be manually enabled with the "--deployv" flag.

Since travis.yml is no longer used, some repos are deleting it, this caused errors since t2d expects it to exist.

This commit makes it possible for t2d to work with repositories that have no travis.yml file. t2d will automatically fallback and enable the --deployv flag whenever no "travis.yml" file is found and the file "variables.sh" exists.

codecov-commenter commented 1 year ago

Codecov Report

Base: 82.74% // Head: 81.64% // Decreases project coverage by -1.09% :warning:

Coverage data is based on head (dfdc9da) compared to base (4d844cd). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head dfdc9da differs from pull request most recent head 1ab0d4d. Consider uploading reports for the commit 1ab0d4d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #191 +/- ## ========================================== - Coverage 82.74% 81.64% -1.10% ========================================== Files 7 7 Lines 591 594 +3 Branches 101 88 -13 ========================================== - Hits 489 485 -4 - Misses 73 79 +6 - Partials 29 30 +1 ``` | [Impacted Files](https://codecov.io/gh/Vauxoo/travis2docker/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo) | Coverage Δ | | |---|---|---| | [src/travis2docker/cli.py](https://codecov.io/gh/Vauxoo/travis2docker/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo#diff-c3JjL3RyYXZpczJkb2NrZXIvY2xpLnB5) | `73.52% <0.00%> (-2.23%)` | :arrow_down: | | [tests/test\_travis2docker.py](https://codecov.io/gh/Vauxoo/travis2docker/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo#diff-dGVzdHMvdGVzdF90cmF2aXMyZG9ja2VyLnB5) | `98.07% <0.00%> (-1.93%)` | :arrow_down: | | [src/travis2docker/travis2docker.py](https://codecov.io/gh/Vauxoo/travis2docker/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo#diff-c3JjL3RyYXZpczJkb2NrZXIvdHJhdmlzMmRvY2tlci5weQ==) | `84.13% <0.00%> (-0.69%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vauxoo)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

moylop260 commented 1 year ago

@luisg123v

Could you approve it functionally and technically, please?

luisg123v commented 1 year ago

Technically LGTM, I will test this functionally tomorrow

antonag32 commented 1 year ago

I agree, my bad, I have added a more useful description to the commit. The PR reflects this description.