search

Vauxoo / travis2docker

This is a Library to transform travis to docker file
BSD 2-Clause "Simplified" License
13 stars 15 forks source link

[IMP] pull image before building #199

Closed antonag32 closed 1 year ago

antonag32 commented 1 year ago

In order to have a better user experience, we must ensure that the latest image is always used, therefore the argument --pull has been added

antonag32 commented 1 year ago

@moylop260 @luisg123v

Can you review? I hard coded the option since it does not hurt and will always be there, seemed easier.

moylop260 commented 1 year ago

Runbot and local dev environment has this parameter enabled

Could you check if it doesn't raise error if it is defined 2 times, please?

if it raises error so could you only add it if it was not added, please?

antonag32 commented 1 year ago

Runbot and local dev environment has this parameter enabled

Could you check if it doesn't raise error if it is defined 2 times, please?

if it raises error so could you only add it if it was not added, please?

I tried running it with --pull repeated twice on the command line and saw no errors. Using Docker 23.0.1