Vauxoo / travis2docker

This is a Library to transform travis to docker file
BSD 2-Clause "Simplified" License
13 stars 15 forks source link

When using --deployv option and providing the $START_SSH variable, the SSH service is not started #200

Closed luisg123v closed 1 year ago

luisg123v commented 1 year ago

Previously, we supported the $START_SSH="1" variable to indicate the SSH service to be started automatically on created containers.

Since we now use the --deployv option, such variable doesn't work anymore, I'm guessing due to the used image.

CC @antonag32 @moylop260

antonag32 commented 1 year ago

Yes, seems like deployv images don't come with sshd setup, at least the ones I have used. I am thinking this can be passed as a build argument to Docker and if enabled ssh can be configured during the image building process.

moylop260 commented 1 year ago

I think vxci or deployv is using this way

But we are using the docker image directly

So, we could copy that part from vxci

Also, using ssh only you need to install the package and start the service

I think it could be executed manually directly into the container from the user since that not all the cases you need to connect using ssh and you could need to install ngrok and add keys too

ssh installed doesn't work by itself

Could you elaborate the case of use where it adds value in your workflow of the day, please?

luisg123v commented 1 year ago

We wouldn't need to install anything. A clean t2d container already has the SSH server installed, it's just not started automatically.

If I create a new one and run:

service ssh start

It starts to run.

My use case is, I use SSH to connect tools to be able to edit and develop.

moylop260 commented 1 year ago

I got it

It was directly in the old docker image

Maybe it could be done from the same way than start_psql & start_odoo:

What do you think @luisg123v ?

luisg123v commented 1 year ago

oh, I like that way!

moylop260 commented 1 year ago

@antonag32

So, let's do it, please