search

Vavinan / pe

0 stars 0 forks source link

Class intance not closed in the diagram #14

Open Vavinan opened 2 months ago

Vavinan commented 2 months ago

image.png

Same like other issue, the ModifyCommand instance is not closed here

nus-se-script commented 2 months ago

Team's Response

Thank you for pointing this out. This is indeed an issue and the activation bar should have been closed. This is not exactly the same sequence diagram but they are drawn by the same person. As such, with the knowledge of how to use PlantUML to properly close off the activation bar in the sequence diagram, I would be able to solve this issue and the one that marks this as a duplicate (See issue #804).

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Bug in Modify Medication Command Sequence Diagram

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

In one of the sequence diagram of the Modify Medication Command section, the activation bar for :ModifyCommand is cropped.

Screenshot 2024-04-19 173426.png Screenshot 2024-04-19 173429.png

[original: nus-cs2113-AY2324S2/pe-interim#944] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing this out. This is indeed an issue and the activation bar should have been closed.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]