search

Vavinan / pe

0 stars 0 forks source link

Take medicine feature not working for the medicine if the dailymed txt file is removed #2

Open Vavinan opened 2 months ago

Vavinan commented 2 months ago

image.png

Even though this feature is working for other medicines, it is not working for the medicine in the last index. This feature flaw will cause inconvenience to the user and it doesn't allow the user to take medicine from the last index. It can be consider as medium severity under some conditions, like if the user took the medicine already, but cannot update the record, so the medicine always has a stock in this record but not in real life, so the user may forget to restock the medicine

soc-pe-bot commented 2 months ago

Team's Response

To be updated.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear error messages

In this case when i try to say take medication 12 it says the index is invalid even though you can see that it is in the list. This is probably because the system is in the afternoon mode (5.16 pm as seen from the third picture) and the afternoon dosage is zero as can be seen from the second picture. However, the error message just says the index is invalid which is confusing for the user.

image.png

image.png

image.png

[original: nus-cs2113-AY2324S2/pe-interim#1414] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for this issue, unfortunately our UG already stated that if you want to use the take command, you have to refer to list -t today, instead of list -t all. Otherwise the specified list index may not be available in the daily list.

image.png

We have also stated in our FAQ as we noticed this confusion since the PE-D:

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** As the CLI says Invalid index specified, its misguiding the user in a sense that, the medicine is not in the list. The program should have informed the user that the medicine is already taken instead of printing `Invalid index specified`.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]