search

VazkiiMods / AkashicTome

The book of books.
27 stars 24 forks source link

Add parameterless constructor to morph message #85

Closed EccentricVamp closed 2 years ago

EccentricVamp commented 2 years ago

Fixes #83

From the error message posted in that issue I traced the error to vazkii.arl.network.NetworkHandler, which expects all messages to have a constructor with no parameters.

MessageMorphTome implements a single constructor which takes a parameter. As a result, NetworkHandler errors out whenever it tries to deserialize the morph message, preventing the Tome from morphing into any of the books it contains.

I fixed this by making adding a parameterless constructor to MessageMorphTome and removing static from modid. I didn't touch the existing constructor, so this shouldn't break anything else.

I've tested this locally on my client with no issues.

EccentricVamp commented 2 years ago

@Alwinfy let me know if there's anything I need to change before this gets merged.

EccentricVamp commented 2 years ago

[edit: removed snarkyness]

I think I can do better, so I'm going to go make my own mod. With blackjack and hookers