VazkiiMods / AkashicTome

The book of books.
27 stars 24 forks source link

1.16.5 forge "Allow all items" not allowing all items #95

Open SparkdotIe opened 2 years ago

SparkdotIe commented 2 years ago

In depth duplicate of: https://github.com/VazkiiMods/AkashicTome/issues/77#issue-1070940082

Mc Version: 1.16.5 Modloader Version: Forge - 36.2.34 Mod Version: AkashicTome-1.4-16

Setting "Allow all items" appears to not allow all items to be put into the book, even if the item in question seemingly has no conflict with the function of the book, such as having an alt click function (Music discs for example)

Problem: Only some items are able to be added to the book, Modded music discs for example, but not vanilla. Extended problem: Discs from the same mod, are not able to be added together when one has already been added

Secondary Problem: Adding the items name to the allowed items list, minecraft:music_disc_13 for example, still does not allow the item to be added, nor does adding the tag "disc" or "music" to the whitelist allow the item to be inserted into the book

The above issues can be replicated with more than discs, such as books with similar names but are separated by nbt tags Cooking for blockheads & Cooking for blockheads [#NoFilter], and items such as ProjectE's Catalytic lens & Philosopher's stone not being allowed after "Allow all items" is enabled.

Screenshots of testing for proof

1a. Modded disc being added successfully (First mod tried) 2022-07-06_06 17 07 2022-07-06_06 16 52

1b. Modded disc being added successfully (Second mod tried) 2022-07-06_06 18 08 2022-07-06_06 17 54

1c. Modded disc being added successfully (Third mod tried) 2022-07-06_06 18 37 2022-07-06_06 18 32

1d. Modded disc being added successfully (Second disc of the first mod tried) 2022-07-06_06 18 48 2022-07-06_06 18 44

Examples of the problems:

2a. Vanilla discs not being able to be put into the book 2022-07-06_06 17 48 2022-07-06_06 17 43

2b. Multiple discs from one mod not being able to be put into the book if one already exists 2022-07-06_06 19 04 2022-07-06_06 19 02

Do forgive me if all these images aren't needed for this report.