VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.26k stars 506 forks source link

Pouch losing all flowers randomly... #1894

Closed Unrepentant-Atheist closed 3 years ago

Unrepentant-Atheist commented 7 years ago

I have no idea what's causing this, but my pouch is losing all the collected flowers randomly.

Forge: 2094 Botania: Botania r1.9-323.jar More mods: https://gist.github.com/anonymous/1c87d469fb7017a15196a39dac963773

Vazkii commented 7 years ago

Can anyone at all reproduce this?

KomradeSpectre commented 7 years ago

I've been able to reproduce the issue on a very similar mod setup, the issue happened to be optifine on that one making items vanish from the inventory until entering any block. The issue with the flower pouch did occur, but vanished the moment optifine was removed.

4rz0 commented 7 years ago

I can reliably reproduce this by putting the flower pouch inside a Backpacks! backpack. When the backpack is closed, all flowers inside the pouch are removed.

Forge is recommended (2099) Backpacks! is 3.1.3 Botania is 335

ridjack commented 7 years ago

I can confirm the above comment from 4rz0 as well.

bookerthegeek commented 7 years ago

That actually from a server standpoint is most likely a good thing. Storage inception causes nbt data overload.

Would request that the flower pouch be blacklisted from entering other portable storage, such a a golden bag of holding or backpacks.

ridjack commented 7 years ago

I mean, the "Backpacks!" mod has you putting backpacks inside of backpacks inside of backpacks. It's kinda all about 'storage inception.'

bookerthegeek commented 7 years ago

True. And after your player data file needs to be reset or edited you usually don't do it again.

Most servers just script it to stop storage inception. Editing player data is a pain when you have to do it multiple times a day.

TsukiyomiSachiko commented 7 years ago

To be fair, since the flower pouch itself doesn't support storing anything other than flowers (therefore not itself) the storage inception part is not at all botanias problem, but more "backpacks!" problem, should probably take that up with them.

williewillus commented 7 years ago

I am still curious what technically is wrong. I suspect the Backpacks! mod is doing something that only considers the main stack NBT tag, except that these flowers are stored in the capability NBT tag, so whatever they do skips our data.

bookerthegeek commented 7 years ago

@JRoffel very true

@williewillus Sorry for the rant.

4rz0 commented 7 years ago

Well, storing other things that can contain things works (IE crates, bits bag), so Botania must be doing something different than the other mods.

williewillus commented 7 years ago

Botania uses the new capability system for this inventory, do the other mods use it?

4rz0 commented 7 years ago

Don't think so. Doesn't look like there was a need for that since everything worked as intended.

williewillus commented 7 years ago

Okay, so it's the Backpacks mod not supporting the new capabilities. do they have a repo?

4rz0 commented 7 years ago

Not that I know of. I'll see if I can contact the creator about that problem.

Not-February commented 7 years ago

I actually just had my flower pouch AND my baubles case randomly empty themselves twice now. I don't know when it happened the first time, but as soon as I noticed I went into creative on my dedicated server to return the items lost to the glitch, and immediately my baubles case was empty again when I checked it.

One thing to note: I don't have the same backpack mod installed as the other people have mentioned in this issue(I have Iron Backpacks instead), nor was I even putting the baubles case/flower pouch anywhere but in my main inventory. They were in my inventory the entire time yet managed to erase all of their contents somehow.

I don't know what's causing it to begin with, but the fact that it happened to me again immediately after going into creative mode to try and fix it may be a clue.

It is also true that I went into creative earlier today in order to test out some things(also on the dedicated server), and it's possible that I simply didn't notice that my flower pouch/baubles case were empty until after the fact; I was focusing on other mods for a while after all, and hadn't had a need to open either.

EDIT: I'm using the recommended Forge for 1.10.2(2099) and these are all the mods I have installed:

https://gist.github.com/Febilian/209f673c10b20217fcb2f977f707a7df

Tamaized commented 7 years ago

^ I've actually noticed this myself with my own mod with any items that have capabilities, looking at a creative window that contains the items would reset them but I just assumed its my own faulty code.

williewillus commented 7 years ago

might be a forge thing then

williewillus commented 7 years ago

Possible forge bug: https://github.com/MinecraftForge/MinecraftForge/issues/2523

4rz0 commented 7 years ago

Sounds very plausible, thanks for finding this!

RobertLSnead commented 7 years ago

Ugh. I just experienced this bug! I'm using Forge 12.18.2.2151 with MC 1.10.2 Current Botania as of today!

williewillus commented 7 years ago

was it on a dedicated server?

RobertLSnead commented 7 years ago

Yes! I just updated my server to 12.18.2.2185 and see if that fixes the bug. Most of the posts are blaming Forge so I updated to see if it fixes the bug. So far so good. I noticed that it goes to zero then fills in the flowers. Hopefully this fixes it.

Twisted-Code commented 7 years ago

I've noticed this happen if I load an NEI cheat mode "save" state that happens to contain a flower pouch. No matter what the pouch contained when I saved it, the pouch loaded by NEI is empty. Any chance you guys can release a hot fix that just uses standard NBT for now? What does compat NBT even do differently anyway?

Tamaized commented 7 years ago

The capability system allows for more control over stuff (in an easier way I should say, this can be done with normal nbt as well with custom handlers and whatnot) and helps out with other mod interactions as well if needed. Last time I looked into this, I could be wrong here, the cap system doesn't update the nbt every single tick meanwhile the non-cap system does. It's a wonderful tool for us modders.

I should also note, afaik, this is fixed in forge 1.11 (could be wrong) and botania isnt going to update the 1.10 builds anymore, again afaik.

Edit: Actually this could also be due to NEI's way of saving and loading states, they prob aren't calling cap NBT serializations

Twisted-Code commented 7 years ago

@Tamaized So those of us that prefer 1.10 for whatever reason (such as the unfortunate fact a lot of mods haven't updated to 1.11 yet) are probably SoL on this issue? Great....

ktole1999 commented 7 years ago

alot of devs are getting to the point of not supporting multiple versions due to time available. i can understand both sides. it is what it is.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

Hubry commented 4 years ago

Go away stale. This still happens, though it's not really reliable. Might need to move to saving the cap on the stack NBT. Still not a huge problem because it's only really affecting creative mode.

csweet89 commented 4 years ago

I can confirm that this happens still, specifically with the latest version and with mods that sort inventory.

dgobi commented 4 years ago

This just happened to me. The only inventories other than my player one the pouch was placed in was a gold chest from the Iron Chests mod. This was in survival mode. The modpack I'm playing is Arcane Anarchy (and it does contain inventory auto sort, Quark, etc) https://www.curseforge.com/minecraft/modpacks/arcane-anarchy

Brycey92 commented 4 years ago

I'm also having this problem in 1.12.2, and I'm using creative mode, Thermal Expansion satchels, and inventory sorting.

OfficialStamper commented 4 years ago

This just happened to me, lost all flowers except the brown ones, after having mistakenly clicked the middle mouse button, which would normally sort inventory.

I suspect the Inventory Sorting mods are at fault.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

Brycey92 commented 4 years ago

Issue is still present, please reopen, Mr. Bot!

ForgottenHero commented 3 years ago

I'm using FTB Omnia which includes Simple Inventory Sorter mod. By middle-mouse-clicking (default key to sort) when I have the flower pouch open, it deleted all flowers except for the stack of Mystical Red Flowers.

Hubry commented 3 years ago

@ForgottenHero cpw/inventorysorter#89

Hubry commented 3 years ago

I believe this is now fixed after 66bd3ae399ed750e97545bbb4fcac5686fc196d1 and 4bbf5fe08d572e74f958926c6ded0416cc9a8e1d putting contents into main item NBT. If anyone can reproduce on 1.16, open a new issue.

Krougal commented 2 years ago

Is this ever going to get fixed for 1.12.2?

Hubry commented 2 years ago

Nope, 1.12.2 is only going to get critical bug fixes (which is still quite a lot of support). Trivial backports may come with them, but the scope of the change fixing this was decently large and the gain is very low - especially when the workaround is simply not going into creative when holding the pouch.

Krougal commented 2 years ago

Fair enough but you are incorrect about the scope of the issue (or I am reporting on the wrong bug thread), using CPW inventory sorter to sort inventory in SURVIVAL will cause all your flowers to disappear. Interestingly it doesn't happen with the old inventory tweaks mod which while sadly discontinued is still an option for 1.12.2 at least.

DoomRater commented 2 years ago

If the same thing happens to the Immersive Engineering Toolbox, there may not be much the Botania team can do about it.

Krougal commented 2 years ago

Did not know it was an issue with the toolbox as well, but not going to try to find out either. Someone else's modpack and I didn't realize it was installed until after I lost a shit ton of flowers, and inventory tweaks is also there so it's redundant besides. If it doesn't get backported I understand, but felt it deserved mentioning.

TheRandomCrafter83 commented 2 years ago

Same thing happens to me. however, mine happens with inventory sorting. I had some flowers in the pouch. accidentally clicked the mouse wheel, which sorts items in an inventory. Almost all of the flowers disappeared. all that was left were the mystical white flowers and the mystical red flowers. everything else was gone. I am using the newest Direwolf 20 modpack btw.

Krougal commented 2 years ago

Same thing happens to me. however, mine happens with inventory sorting. I had some flowers in the pouch. accidentally clicked the mouse wheel, which sorts items in an inventory. Almost all of the flowers disappeared. all that was left were the mystical white flowers and the mystical red flowers. everything else was gone. I am using the newest Direwolf 20 modpack btw.

If it's in 1.12.2 then it is likely CPW Inventory Sorter. I believe the issues been corrected/or just resolved itself in later versions but was never backported. If you're in some other version then I don't know.

TheRandomCrafter83 commented 2 years ago

Same thing happens to me. however, mine happens with inventory sorting. I had some flowers in the pouch. accidentally clicked the mouse wheel, which sorts items in an inventory. Almost all of the flowers disappeared. all that was left were the mystical white flowers and the mystical red flowers. everything else was gone. I am using the newest Direwolf 20 modpack btw.

If it's in 1.12.2 then it is likely CPW Inventory Sorter. I believe the issues been corrected/or just resolved itself in later versions but was never backported. If you're in some other version then I don't know.

I suppose I should mention the latest Direwolf20 pack is 1.18.2 version of minecraft.