VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.27k stars 505 forks source link

EMI compat for Corporea requests #4200

Open Aegide opened 1 year ago

Aegide commented 1 year ago

Mod Loader

Fabric

Minecraft Version

1.19.2

Botania version

1.19.2-436

Modloader version

Fabric 0.14.9

Issue description

When next to a Corporea Index and viewing an inventory (or a recipe)


The corporea keybind works for :


But it doesn't work for :


It also doesn't for EMI graph, but that's an intended behavior.

Steps to reproduce

No response

Other information

No response

artemisSystem commented 1 year ago

It also doesn't for EMI graph, but that's an intended behavior.

What makes you say that's intended?

Aegide commented 1 year ago

If you perform a Corporea request, the feedback that "a request was attempted" can be found in the chat.

While you're using an EMI graph, you cannot see the chat, and therefore cannot get any feedback about what you're doing.

I understand that it would be nice to be able to do Corporea requests while using EMI graph

But i am not a fan of doing "actions" with no clear visual feedback.

TheRealWormbo commented 1 year ago

Maybe that's more of a thing to be "fixed" about EMI's graph view? Other modded fullscreen menus (e.g. fullscreen map views) often provide access to chat messages.

TheRealWormbo commented 5 months ago

There seems to be a restriction in EMI's API for retrieving the hovered stack. I can get the CorporeaInputHandler to recognize EMI's recipe and BOM screens, but EmiApi::getHoveredStack only returns non-empty results when hovering over an item in the item list sidebar, not for any items shown in the recipe displays.