VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.28k stars 505 forks source link

Flugel Tiara's bar overrides Tough As Nails' water bar in hotbar #4414

Open TheEnderek0 opened 1 year ago

TheEnderek0 commented 1 year ago

Mod Loader

Forge

Minecraft Version

1.18.2

Botania version

1.18.2-435

Modloader version

Forge: 40.2.9

Modpack info

No response

The latest.log file

-

Issue description

When you play in a modpack with both Botania and Tough As Nails, the water/hydration bar is overriden when you equip Flugel Tiara with the wings bar. This is very annoying as you cannot see the hydration level when wearing the tiara.

Possible solution would be to account for other bars that may be present in that spot and move the bar upward if needed.

Steps to reproduce

  1. Make a modpack with Tough As Nails and Botania (and their dependents)
  2. Create a new world in creative
  3. Equip flugel tiara
  4. Change to survival mode
  5. Experience the bug

Other information

No response

anoomolu commented 11 months ago

Was able to reproduce this on 1.19.2, not only with Tough As Nails but also Overflowing Bars.

At least for TAN, setting the thirst_top_offset in the client.toml to -10 will place it neatly above the flight bar.

TheRealWormbo commented 4 months ago

The main problem here is that Botania doesn't know where other mobs put their HUD elements. There recently was a fix (#4653) for two vanilla conditions that caused the flight bar to overlap, but mods will likely require compatibility code to move the flight bar out of the way. I'll have a look at the two mods mentioned, and see if there's a way to detect them without depending on them.