search

VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.28k stars 506 forks source link

Same food with different NBT counts toward Gourm streaks #4455

Open anoomolu opened 1 year ago

anoomolu commented 1 year ago

Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.19.2

Botania version

1.19.2-440

Modloader version

Forge: 43.2 / Fabric Loader 0.14.21 and Fabric API 0.76.0

Modpack info

No response

The latest.log file

n/a

Issue description

  1. Naming a food item in an anvil will make it count as a separate entry for gourmaryllis streaks. This seems like an exploit, since it only costs 1 level to name 64 items.
  2. Sus stews made from different flowers count as separate entries for gourm streaks too. It'd be nice if this was kept, but I think just removing the Gourm's ability to check NBT to differentiate foods is a simpler approach (as Wormbo suggested).

Steps to reproduce

  1. Get food (e.g. Steak)
  2. Name half of it Steak1 in an anvil
  3. Observe that the two foods don't receive diminishing returns

Other information

No response

williewillus commented 1 year ago

should probably make it insensitive then have an allowlist, bc things like sandwich mods would want to be nbt sensitive

TheRealWormbo commented 1 year ago

It may be even more complicated than that. The Gourmaryllis currently saves the entire item stack it consumed, which not only includes the name, but also the stack size. Since the Gourmaryllis always consumes entire stacks (but ignores the stack size for mana production), it should even be possible to alternate stack sizes 1 and 2 to avoid the repetition penalty.

[edit] Scratch that, while it does save all that information, it only actually compares item type and additional NBT data.