search

VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.25k stars 497 forks source link

[Suggestion] Utilise Common Tags #4502

Open xanthian opened 7 months ago

xanthian commented 7 months ago

Mod Loader

Fabric

Minecraft Version

1.20.1

Botania version

1.20.1-441

Modloader version

Quilt 0.22

Modpack info

Stitched - https://modrinth.com/modpack/stitched

The latest.log file

https://modrinth.com/modpack/stitched

Issue description

Consider utilising common tags in recipes. For example.

Crafty Crate - Use c:workbench in place of minecraft:crafting_table Currently only the MC default crafting_table is usable, there are many mods that add other crafting_tables.

Steps to reproduce

No response

Other information

No response

TheRealWormbo commented 7 months ago

While conventional tags are indeed a Fabric interface, fewer of those seem to actually be standardized than you'd think. (e.g. c:workbench isn't mentioned in https://github.com/FabricMC/fabric/tree/1.20.3/fabric-convention-tags-v1/src/generated/resources/data/c/tags/items) Recipes are modifiable statically via data packs or dynamically via mods like KubeJS, which both are ways pack authors can use to adapt individual mods' recipes to better fit the combination of mods in the pack. (But I do agree that Botania should probably start using the existing convention tags, even though that will make it necessary to define certain recipes separately for Forge and Fabric.)

artemisSystem commented 6 months ago

We'll probably look into this in 1.21 with the tag unification: https://github.com/neoforged/NeoForge/pull/135 / https://github.com/FabricMC/fabric/pull/3310

TelepathicGrunt commented 5 months ago

tag unification for 1.21 modloaders will have c:player_workstations/crafting_tables now

Added cause of this use case being linked to the unification prs lol

TelepathicGrunt commented 5 months ago

Also, surprised that Crafty Craft considers c:workbench to contain Crafting table when i assumed people saw that tag for villager job site blocks. At least in tag rework, it'll be much more clear of what belongs where