search

VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.26k stars 506 forks source link

1.20.1 - PistonStructureResolverMixin Server crash #4527

Closed Gamerbolts closed 8 months ago

Gamerbolts commented 8 months ago

Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.20.1-442

Modloader version

47.2.16

Modpack info

Heavily modified ATM9

The latest.log file

https://gist.github.com/Gamerbolts/528f6e8aa1f5e2229bacc0a3c0531035

Issue description

I am not sure what happened I was running around exploring the world and crashed. I think a piston did something somewhere I could not see.

Steps to reproduce

No response

Other information

crash-2023-12-30_15.29.56-server.txt

TheRealWormbo commented 8 months ago

How heavily modified? You appear to be running a bunch of Fabric mods on a post-fork Forge version, which means you use a Fabric compatibility mod and a Forge version that may or may not be unstable.

The crash your log file shows does indeed happen from a mixin for piston pushing logic, which requires Forge's access transformer features to work properly. This works with Forge versions 47.1.3 (the latest version before most Forge devs forked NeoForged) and 47.1.47, but as not been tested on any newer version of the mod loader. Can you maybe downgrade to one of those two versions and check if it still causes issues?

Gamerbolts commented 8 months ago

Quite heavily modded. I added about 200 mods to ATM9 which gave me a total of 678. I do have neoforge connector and forgified fabric in the pack. I'll try those two earlier versions of forge to see if that works. Thanks for the help

lgc2333 commented 8 months ago

+1 crash-2024-01-01_18.39.44-server.txt

TheRealWormbo commented 8 months ago

Thank you. A fix is already in the pipeline and probably gets released soon.

liny-fox commented 8 months ago

Just tested by creating a blank modpack in the curse forge loader and installing botaina and its required dependencies and placing a piston and a button next to it and the server instantly crashes when pressing the button.

lgc2333 commented 8 months ago

try this before the next version release https://github.com/lgc2333/Botania/actions/runs/7383125195 (PR #4528 did this)

TheRealWormbo commented 8 months ago

try this before the next version release https://github.com/lgc2333/Botania/actions/runs/7383125195

What does that do? (And how does it relate to this bug?)

artemisSystem commented 8 months ago

Fix is now out: https://forum.violetmoon.org/d/158-botania-1201-443-released