search

VazkiiMods / Botania

A tech mod for Minecraft themed around the magic of nature and plant life.
http://botaniamod.net/index.html
Other
1.26k stars 506 forks source link

Virus Items (nullodermal virus, ect) doesn't work on donkeys or mules #4563

Open NolanHewitt opened 7 months ago

NolanHewitt commented 7 months ago

Mod Loader

Fabric

Minecraft Version

1.20.1

Botania version

443

Modloader version

Quilt 0.23 QFAPI 7.4.0

Modpack info

No response

The latest.log file

https://gist.github.com/NolanHewitt/23436fb3a43f1c1a1c98c7b2e1cc7fd7

Issue description

All the wiki pages say that these items work on donkeys and mules but it only seems to work on horses. Not sure if this is an intentional change that happened at some point or something that broke on modern versions of the mod.

Steps to reproduce

No response

Other information

No response

anoomolu commented 7 months ago

Hiya. The lexicon only mentions being able to infect horses, and it looks like the code for the item only refers to the Horse entity. As far as I'm aware, it's only meant to work on horses anyways.

TheRealWormbo commented 5 months ago

I assume the reason this was changed from "any horse-like mob" to just horses is that "any horse-like mob" started to include more and more clearly non-horse mobs, such as llamas, trader llamas, and camels. (Not even counting any modded rideable horse-like mobs that may or may not actually be horses.) I'll leave this open until we figure out whether we want to maybe switch to an entity tag or just stick with vanilla horses.

It should also be noted that the only "official" Botania documentation is the Lexica Botania. I'm not aware of any official wiki, so if Botania and any particular wiki disagree, the wiki is probably wrong.